You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The lookups are not exhaustive. Some values are mapped and some are allowed to pass through the lookup function.
This means its very easy to accidentally add a key-value pair to the lookup without realising it's currently being allowed to pass through the function.
A recent example of this was the word 'professional' which was being used for Occupation (pass through) but also for Assessors (defined as a key-value to be mapped to 'Professional Assessor').
So we should get a list of values that are passed through and write tests to ensure they don't get overwritten in the future.
Also add a comment to the file to remind devs to do this going forward.
To facilitate this ticket we need to get a list of all calls to the 'lookup' function and distinguish the values that are allowed to pass through then write tests to check that the lookup function is returning the value passed into it.
The text was updated successfully, but these errors were encountered:
The lookups are not exhaustive. Some values are mapped and some are allowed to pass through the lookup function.
This means its very easy to accidentally add a key-value pair to the lookup without realising it's currently being allowed to pass through the function.
A recent example of this was the word 'professional' which was being used for Occupation (pass through) but also for Assessors (defined as a key-value to be mapped to 'Professional Assessor').
So we should get a list of values that are passed through and write tests to ensure they don't get overwritten in the future.
Also add a comment to the file to remind devs to do this going forward.
To facilitate this ticket we need to get a list of all calls to the 'lookup' function and distinguish the values that are allowed to pass through then write tests to check that the lookup function is returning the value passed into it.
The text was updated successfully, but these errors were encountered: