Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests For Lookups #2607

Open
drieJAC opened this issue Nov 14, 2024 · 0 comments
Open

Add Tests For Lookups #2607

drieJAC opened this issue Nov 14, 2024 · 0 comments

Comments

@drieJAC
Copy link
Contributor

drieJAC commented Nov 14, 2024

The lookups are not exhaustive. Some values are mapped and some are allowed to pass through the lookup function.
This means its very easy to accidentally add a key-value pair to the lookup without realising it's currently being allowed to pass through the function.
A recent example of this was the word 'professional' which was being used for Occupation (pass through) but also for Assessors (defined as a key-value to be mapped to 'Professional Assessor').
So we should get a list of values that are passed through and write tests to ensure they don't get overwritten in the future.
Also add a comment to the file to remind devs to do this going forward.

To facilitate this ticket we need to get a list of all calls to the 'lookup' function and distinguish the values that are allowed to pass through then write tests to check that the lookup function is returning the value passed into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant