jackdbus: Stop recurrent wakeups when no save is pending #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most processing happens as a result of an incoming DBus event. The only case when a timed processing is needed is due to an pending save. Instead of implementing a full event loop just run the timed loop while a save is pending, and use an infinite timeout otherwise. Fixes: jackaudio#962
|
The PR changes seem fine, but if one is using jack the idea of saving battery is non-sensical. |
Running jackdbus does not equal running jack. People will have jackdbus running in the background continously, even if they use jack just sometimes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most processing happens as a result of an incoming DBus event. The only case when a timed processing
is needed is due to an pending save.
Instead of implementing a full event loop just run the timed loop while a save is pending, and use an
infinite timeout otherwise.
Fixes: #962