Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

posts/grpc-web-istio/ #1

Closed
utterances-bot opened this issue Mar 25, 2022 · 5 comments
Closed

posts/grpc-web-istio/ #1

utterances-bot opened this issue Mar 25, 2022 · 5 comments

Comments

@utterances-bot
Copy link

utterances-bot commented Mar 25, 2022

GRPC & GRPC-Web multiplexed in Istio · jackieli.dev

Expose GRPC & GRPC-Web via One Port in Istio

https://jackieli.dev/posts/grpc-web-istio/

Repository owner deleted a comment from jackieli-tes Mar 25, 2022
Copy link

If you use grpc-web and istio 1.1 you should not need to create the EnvoyFilter, see istio/istio#10064 for more details. I came across that update when looking over this venilnoronha/grpc-web-istio-demo#3 example. I'm trying to setup on knative though, so glad you had an example of the EnvoyFilter b/c I'll need to create it myself still

Copy link
Owner

jackielii commented Jun 7, 2022

Yes, you're right. Although the example you linked uses the sidecar. I.e. if you enable the side car for the deployment / namespace, then it'll automatically enable the grpc-web filter on the side car envoy. This was how we've done it before. It obviously will allow grpc-web to be proxied on the gateway using the same port as https/http, but doesn't allow grpc to pass through.

So my method not only eliminates the need to the side car, but also enables grpc to be multiplexed via the https port.

Copy link

Jackielii -
@jackie li - i tried with your example.
I see that the docker image for this is missing. Where can I get docker image for it or how do I build the same.

@jackielii
Copy link
Owner

Hi @muralaris the image is built by the ko tool. It builds the go code, builds the image and deploys them in one step.

The magic happens with command export KO_DOCKER_REPO=tespkg ko apply -f config/. Here you want to change the KO_DOCKER_REPO to your docker hub id, then everything else should just work.

Hope this helps.

@jackielii jackielii reopened this Mar 13, 2023
Copy link
Owner

Repository owner locked and limited conversation to collaborators Sep 28, 2023
@jackielii jackielii converted this issue into discussion #2 Sep 28, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants