Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

🌙 Dark mode #63

Open
2 tasks
jackyzha0 opened this issue Mar 1, 2021 · 7 comments
Open
2 tasks

🌙 Dark mode #63

jackyzha0 opened this issue Mar 1, 2021 · 7 comments
Assignees

Comments

@jackyzha0
Copy link
Owner

jackyzha0 commented Mar 1, 2021

'nuff said

const theme = {
  colors: {
    background: '#111111',
    codeHighlight: '#ffffff08',
    border: '#565656',
    text: '#faf9f5',
    error: '#ee1111',
  },
}

AC:

  • Add toggle to switch themes
  • Persist option to local storage
@jackyzha0 jackyzha0 self-assigned this Mar 1, 2021
@Siddhant-K-code
Copy link
Contributor

I can work on this!

@Siddhant-K-code
Copy link
Contributor

I saw there is a lot of usage of colors on diff pages, we can add it all under once in app.js ??

This May Help

@jackyzha0
Copy link
Owner Author

ctrl-v actually uses styled-components under the hood and we use a Theme Provider! Code here: https://github.com/jackyzha0/ctrl-v/tree/master/frontend/src/theme

Probably just a toggle to switch the themes in here. Will add a colour palette soon

@jackyzha0
Copy link
Owner Author

ctrl-v actually uses styled-components under the hood and we use a Theme Provider! Code here: https://github.com/jackyzha0/ctrl-v/tree/master/frontend/src/theme

Probably just a toggle to switch the themes in here. Will add a colour palette soon

updated

@Siddhant-K-code
Copy link
Contributor

It is looking this with new color pallete:
image

image

will try to add a toggle, localStorage, and will try to send PR asap

@jackyzha0
Copy link
Owner Author

It is looking this with new color pallete:
image

image

will try to add a toggle, localStorage, and will try to send PR asap

any possibility we can change the default theme of the editor to be atom dark when dark mode toggle is turned on too?

@Siddhant-K-code
Copy link
Contributor

Yes, and I was also thinking of providing options at the top right of the editor for various themes :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants