Comments Component now Fails to Load

[harrellbm]

Describe the bug
I previously had to comments component up and running on my garden. But then updated to the most recent commits and realized that it now fail to load at all. There are not errors in the console and a quick inspection looks like the afterbody div just doesn't exist anymore.

To Reproduce
Steps to reproduce the behavior:

updated branch to commit #1575

Load site with comments component

Nothing happens

Checked on desktop using chrome and edge
Checked on mobile using chrome and safari all with the same result

Expected behavior
Giscus to load

Screenshots and Source

You can help speed up fixing the problem by either

My Fork https://github.com/harrellbm/Quartz-Garden
Site this can be observed on https://harrellbm.github.io/Quartz-Garden/

Desktop (please complete the following information):

• Quartz Version: [e.g. v4.1.2]
• node Version: [e.g. v18.16]
• npm version: [e.g. v10.1.0]
• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]

Additional context
Add any other context about the problem here.

[xlinker1]

After updating and trying to use the Comments component for the first time, I ran into the same problem. I've followed all instructions in https://quartz.jzhao.xyz/features/comments . 🥺

commit 1ab9c91df1df799f7a1004200ff890b144d00f19 (HEAD -> v4, upstream/v4)
Author: Aaron Pham <contact@aarnphm.xyz>
Date:   Sun Nov 10 18:13:12 2024 -0500

    feat(mermaid): improvement navigation (#1575)

    * feat(mermaid): custom stuff

[saberzero1]

Can you check if #1586 fixes this issue?

[harrellbm]

I can confirm the patch works perfectly! Thanks for the quick response!

[lone17]

I still encounter this issue. As I understand, the first condition disables comments if comments are absent in the frontmatter, which I believe is not the intended behaviour.

quartz/quartz/components/Comments.tsx

Lines 30 to 33 in e1d754e

	const disableComment: boolean =
	!fileData.frontmatter?.comments || fileData.frontmatter?.comments === "false"
	if (disableComment) {
	return <></>

I also looked at @harrellbm's fork to see why it worked for him. Turns out he applied the fix manually and mistakenly removed the return statement after the check.

https://github.com/harrellbm/Quartz-Garden/blob/384db9163d48a327a66a0aeb156be3df8a2af58c/quartz/components/Comments.tsx#L30-L33

Just a quick fix so I made the PR at #1625.