Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong handling of ridge values<-1 in inversPeaksAndValleys #9

Open
siliotar opened this issue Oct 23, 2022 · 1 comment
Open

Wrong handling of ridge values<-1 in inversPeaksAndValleys #9

siliotar opened this issue Oct 23, 2022 · 1 comment
Labels
core Affects the core of the App spline editor Affects the (legacy) spline editor

Comments

@siliotar
Copy link

if (a - 0.6666667 < -1.5) {

'a' between -0.6666667 and 0. So a - 0.6666667 will be between -1.3333337 and -0.6666667.

@jacobsjo
Copy link
Owner

You are absolutely right. I think this line should read

  if (a + 0.666667 < 0)

and the if above shouldn't have the ridge < -1 case.

I don't think the case with ridge < -1 is used anyways, but it makes sense to have this function correct in all cases anyways. I'll fix it eventually.

@jacobsjo jacobsjo changed the title Useless if statement Wrong handling of ridge values<-1 in inversPeaksAndValleys Oct 31, 2022
@jacobsjo jacobsjo added the core Affects the core of the App label Oct 31, 2022
@jacobsjo jacobsjo added the spline editor Affects the (legacy) spline editor label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Affects the core of the App spline editor Affects the (legacy) spline editor
Projects
None yet
Development

No branches or pull requests

2 participants