You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In ./reader/configreader.go you call jww.Fatalf() which calls log.Fatalf() which calls os.Exit(1) which provides no opportunity for the parent program to recover from a configuration exception, even if done in a goroutine.
Recommend updating these jww.Fatalf() calls to jww.Panicf() so that the program can recover if they have a clean path to do so.
Happy to put together a pull request if you would like.
The text was updated successfully, but these errors were encountered:
In
./reader/configreader.go
you calljww.Fatalf()
which callslog.Fatalf()
which callsos.Exit(1)
which provides no opportunity for the parent program to recover from a configuration exception, even if done in a goroutine.Recommend updating these
jww.Fatalf()
calls tojww.Panicf()
so that the program can recover if they have a clean path to do so.Happy to put together a pull request if you would like.
The text was updated successfully, but these errors were encountered: