Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configReader should not call jww.Fatalf #8

Open
MightyE opened this issue Jan 18, 2016 · 2 comments
Open

configReader should not call jww.Fatalf #8

MightyE opened this issue Jan 18, 2016 · 2 comments

Comments

@MightyE
Copy link

MightyE commented Jan 18, 2016

In ./reader/configreader.go you call jww.Fatalf() which calls log.Fatalf() which calls os.Exit(1) which provides no opportunity for the parent program to recover from a configuration exception, even if done in a goroutine.

Recommend updating these jww.Fatalf() calls to jww.Panicf() so that the program can recover if they have a clean path to do so.

Happy to put together a pull request if you would like.

@jacobstr
Copy link
Owner

I believe! Pull request would be appreciated.

@ianomad
Copy link

ianomad commented Aug 19, 2016

Here you go! @ #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants