Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drawLabel and drawHover inconsistencies #1435

Open
3 tasks
jacomyal opened this issue Jun 26, 2024 · 0 comments
Open
3 tasks

drawLabel and drawHover inconsistencies #1435

jacomyal opened this issue Jun 26, 2024 · 0 comments
Milestone

Comments

@jacomyal
Copy link
Owner

Here are some inconsistencies:

  • drawLabel (for nodes and edges) and drawHover (for nodes only) could be static program class attributes, as they don't require anything from the program instances themselves
  • They are actually required as non-static attributes for NodePrograms and EdgePrograms
  • They are defined as static attributes of NodeImageProgram, but non-static for EdgeCurveProgram
  • The getNodeImageProgram factory allows simply overriding the drawLabel and drawHover attributes, but the createEdgeCurveProgram doesn't (and their name don't fit either...)

So, actions to take:

  • Check that all factories have similar names (getSomething or createSomething, but the same everywhere)
  • Check that all factories allow simply overriding drawLabel (and drawHover for nodes)
  • Clarify everywhere whether drawLabel (and drawHover for edges) should be static or not
@jacomyal jacomyal added this to the v3 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant