You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
drawLabel (for nodes and edges) and drawHover (for nodes only) could be static program class attributes, as they don't require anything from the program instances themselves
The getNodeImageProgram factory allows simply overriding the drawLabel and drawHover attributes, but the createEdgeCurveProgram doesn't (and their name don't fit either...)
So, actions to take:
Check that all factories have similar names (getSomething or createSomething, but the same everywhere)
Check that all factories allow simply overriding drawLabel (and drawHover for nodes)
Clarify everywhere whether drawLabel (and drawHover for edges) should be static or not
The text was updated successfully, but these errors were encountered:
Here are some inconsistencies:
drawLabel
(for nodes and edges) anddrawHover
(for nodes only) could bestatic
program class attributes, as they don't require anything from the program instances themselvesNodePrograms
andEdgePrograms
static
attributes ofNodeImageProgram
, but non-static forEdgeCurveProgram
getNodeImageProgram
factory allows simply overriding thedrawLabel
anddrawHover
attributes, but thecreateEdgeCurveProgram
doesn't (and their name don't fit either...)So, actions to take:
getSomething
orcreateSomething
, but the same everywhere)drawLabel
(anddrawHover
for nodes)drawLabel
(anddrawHover
for edges) should bestatic
or notThe text was updated successfully, but these errors were encountered: