Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fitViewportToNodes does not work with custom bounding box #1472

Closed
jacomyal opened this issue Sep 30, 2024 · 0 comments
Closed

fitViewportToNodes does not work with custom bounding box #1472

jacomyal opened this issue Sep 30, 2024 · 0 comments

Comments

@jacomyal
Copy link
Owner

After discussing with @Rich5 (#1471), It seems that the fitViewportToNodes does not properly work when using a custom bounding box (set with sigma#setCustomBBox).

Actions to take:

  1. Create a reproduction case for that issue in the StoryBook to validate the problem
  2. Also check with other options that could similarly break that interaction (autoRescale setting, for instance)
  3. Add a regression test to @sigma/utils
  4. Fix the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant