Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a primary key to SqlServerVersions table #2

Closed
reharmsen opened this issue Jun 29, 2018 · 2 comments
Closed

Add a primary key to SqlServerVersions table #2

reharmsen opened this issue Jun 29, 2018 · 2 comments
Assignees

Comments

@reharmsen
Copy link
Contributor

The SqlServerVersions table does not contain a primary key, this won't allow us to replicate this table through our central DBADA database.

One way would be to create a clustered key on 'MajorVersionNumber', 'MinorVersionNumber' and 'ReleaseDate', this can be done by adding this to the table creation.

CONSTRAINT [PK_SqlServerVersions] PRIMARY KEY CLUSTERED
(
[MajorVersionNumber] ASC,
[MinorVersionNumber] ASC,
[ReleaseDate] ASC
)

@jadarnel27
Copy link
Owner

Sounds great to me! I didn't really consider replication when working on this. Thanks for bringing it up!

I'll plan on getting to it this weekend.

@jadarnel27
Copy link
Owner

@reharmsen I've published a new release that includes this fix, let me know if you have any issues with it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants