Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable version in JaegerSpec #166

Closed
pavolloffay opened this issue Dec 10, 2018 · 7 comments
Closed

Configurable version in JaegerSpec #166

pavolloffay opened this issue Dec 10, 2018 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pavolloffay
Copy link
Member

Should we provide a simple conf property to specify the version? Note that at the moment we allow overriding images for each individual component.

IIRC p8s and etcd operators offers this.

@jpkrohling
Copy link
Contributor

+1

@jpkrohling jpkrohling added enhancement New feature or request good first issue Good for newcomers labels Jan 15, 2019
@jpkrohling
Copy link
Contributor

This should be relatively easy to do:

  • Add a Version string as part of the JaegerCommonSpec
  • Change the normalize() function to set jaeger.Spec.Version to viper.GetString("jaeger-version") if it's empty
  • Change all usages of viper.GetString("jaeger-version") to get the version from the newly created property jaeger.Spec.Version
  • Tests
  • Documentation (probably only a small entry in the readme)

@rajdhandus
Copy link

Can I please pick this up and work on it.. ?

@jpkrohling
Copy link
Contributor

It's yours :-)

@jordo1138
Copy link

jordo1138 commented Apr 18, 2019

@pavolloffay I'm looking to do just what you mentioned, override component version to use "latest" tag since I want to test this change from this morning jaegertracing/jaeger#1473
and since the operator version is 1.11.1 it's pulling the images tagged at 1.11 right? this change currently only in the latest tag, so in part, question I have is that I'm using strategy: Production but I'm not sure where should override the version for each component like jaeger-collector etc?

@jpkrohling
Copy link
Contributor

@jordo1138 You can follow the all-in-one-with-options.yaml example as reference. All components (collector, query, ...) support the image property.

@jpkrohling
Copy link
Contributor

I'm closing, as we've decided that the Operator will manage the underlying Jaeger version, based on its version (Operator v1.13 == Jaeger v.1.13). When the operator is updated to, say, 1.14, it will take care to bring all managed instances to the same version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants