Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: On Openshift, jaeger-operator does not respect hosts set in ingress section #2334

Closed
xmj opened this issue Sep 28, 2023 · 4 comments · Fixed by #2409
Closed

[Bug]: On Openshift, jaeger-operator does not respect hosts set in ingress section #2334

xmj opened this issue Sep 28, 2023 · 4 comments · Fixed by #2409
Labels
bug Something isn't working

Comments

@xmj
Copy link

xmj commented Sep 28, 2023

What happened?

According the Jaeger CRD, and the PR merged in
#749
it should be possible to set dynamic hostnames for the ingress resource.

On openshift, this is not the case: the hostname of the route is always a composite of the jaeger instance name and the namespace it is deployed into.

See https://github.com/jaegertracing/jaeger-operator/blob/main/pkg/route/query.go#L48

Could you please enhance jaeger-operator to respect the hosts: / tls[].hosts lists?

Thank you!

Steps to reproduce

Deploy jaeger operator and configure instance like so:

apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  labels:
    jaegertracing.io/operated-by: openshift-distributed-tracing.jaeger-operator
  name: jaeger
  namespace: openshift-distributed-tracing
spec:
<snip>
  strategy: production
<snip>
  ingress:
    hosts:
      - {{ .Values.jaeger.hostname }}
    tls:
      - hosts:
          - {{ .Values.jaeger.hostname }}
        secretName: jaeger-jaeger-elasticsearch
    openshift:
        {"namespace": "openshift-distributed-tracing", "resource": "pods",
        "verb": "get"}
    options: {}
    resources: {}
    security: oauth-proxy
<snip>

You can use any FQDN instead of {{ .Values.jaeger.hostname }}, as per the route/query.go configuration it will be ignored anyway.

Expected behavior

Ingress route is created with FQDN specified in the ingress.hosts / ingress.tls.hosts values.

Relevant log output

No response

Screenshot

No response

Additional context

No response

Jaeger backend version

v1.47.0-2 (RH/Openshift edition)

SDK

No response

Pipeline

No response

Stogage backend

ElasticSearch

Operating system

Openshift / RHEL

Deployment model

k8s

Deployment configs

No response

@xmj xmj added the bug Something isn't working label Sep 28, 2023
@pavolloffay
Copy link
Member

cc) @rubenvp8510 @iblancasa

type JaegerIngressSpec struct {

@xmj
Copy link
Author

xmj commented Jan 5, 2024

cc) @rubenvp8510 @iblancasa

type JaegerIngressSpec struct {

Is there anything I can do to help move this ticket forward?

@iblancasa
Copy link
Collaborator

@xmj can you check if the changes done in #2409 solve your problem?

@xmj
Copy link
Author

xmj commented Jan 9, 2024

Thanks for the PR @iblancasa, looks good.
I'm not sure how to replace openshift's jaeger deployment with a custom-built one from this PR yet. Once I do, I'll let you know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants