Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'ingester.options.ingester.deadlockInterval' from examples #717

Closed
jpkrohling opened this issue Oct 21, 2019 · 5 comments
Closed
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@jpkrohling
Copy link
Contributor

The default value for the property ingester.deadlockInterval has been changed to 0 for Jaeger 1.15. After Jaeger 1.15 is released but before the Operator 1.15 is released, we should consider removing the option that sets this value to 0, as will be just noise by then.

Example:

ingester:
options:
kafka:
consumer:
topic: jaeger-spans
brokers: my-cluster-kafka-brokers.kafka:9092
ingester:
deadlockInterval: 0

@jpkrohling
Copy link
Contributor Author

Note that a new example using the same flag is part of #713.

@amila-ku
Copy link
Contributor

i would like to work on this.

@jpkrohling
Copy link
Contributor Author

Thank you for your interest in this one, but it isn't ready to be done right now, given that it requires Jaeger 1.15, which hasn't been released yet. I can assign it to you anyway if you want, but we should have quite a few other issues that are suitable as a good-first-issue, in case you are interested.

@amila-ku
Copy link
Contributor

then i will checkout other ones.

@jpkrohling jpkrohling added needs-triage New issues, in need of classification and removed needs-triage New issues, in need of classification labels Dec 16, 2019
@jpkrohling
Copy link
Contributor Author

@amila-ku, would you still be interested in sending a PR for this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants