Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-trace search should allow navigation between results #91

Open
yurishkuro opened this issue Oct 7, 2017 · 1 comment
Open

In-trace search should allow navigation between results #91

yurishkuro opened this issue Oct 7, 2017 · 1 comment

Comments

@yurishkuro
Copy link
Member

Currently if we use the Search box on the trace view, it grays out all spans not matching the search and keeps the matching span in normal opacity. However, on a large trace this makes it difficult to find the matching spans.

Suggestion:

  • scroll the trace view to the first matching span automatically if it's not currently in the view port
  • add the navigation buttons to the Search bar that allow jumping forwards/backwards between the matching span, similar to how in-page search works in Chrome - it shows up and down arrows, and by default the Enter key jumps to the next match.

image

@tiffon
Copy link
Member

tiffon commented Oct 16, 2017

Great suggestion.

FYI, something tangentially related, in #93 I've added shortcuts to scroll to prev / next visible span. When a search is in-progress, this skips spans that are filtered out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants