Skip to content

Commit 8bd42d3

Browse files
committed
Fix rebase
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
1 parent 4108523 commit 8bd42d3

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

cmd/agent/app/reporter/tchannel/collector_proxy.go

+7-5
Original file line numberDiff line numberDiff line change
@@ -26,19 +26,21 @@ import (
2626
type ProxyBuilder struct {
2727
reporter reporter.Reporter
2828
manager httpserver.ClientConfigManager
29+
tchanRep *Reporter
2930
}
3031

3132
// NewCollectorProxy creates ProxyBuilder
3233
func NewCollectorProxy(builder *Builder, mFactory metrics.Factory, logger *zap.Logger) (*ProxyBuilder, error) {
33-
b := &ProxyBuilder{}
3434
r, err := builder.CreateReporter(logger)
3535
if err != nil {
3636
return nil, err
3737
}
3838
tchannelMetrics := mFactory.Namespace("", map[string]string{"protocol": "tchannel"})
39-
b.reporter = reporter.WrapWithMetrics(r, tchannelMetrics)
40-
b.manager = httpserver.WrapWithMetrics(httpserver.NewCollectorProxy(r.CollectorServiceName(), r.Channel()), tchannelMetrics)
41-
return b, nil
39+
return &ProxyBuilder{
40+
tchanRep: r,
41+
reporter: reporter.WrapWithMetrics(r, tchannelMetrics),
42+
manager: httpserver.WrapWithMetrics(httpserver.NewCollectorProxy(r.CollectorServiceName(), r.Channel()), tchannelMetrics),
43+
}, nil
4244
}
4345

4446
// GetReporter returns Reporter
@@ -53,6 +55,6 @@ func (b ProxyBuilder) GetManager() httpserver.ClientConfigManager {
5355

5456
// Close closes connections used by proxy.
5557
func (b ProxyBuilder) Close() error {
56-
b.reporter.Channel().Close()
58+
b.tchanRep.Channel().Close()
5759
return nil
5860
}

0 commit comments

Comments
 (0)