Change to tagged metrics in agent (#950)

Use tags in agent metrics
jaegertracing · Jul 24, 2018 · ba7d9b8 · ba7d9b8
1 parent df4a5e0
commit ba7d9b8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 20 deletions.
diff --git a/cmd/agent/app/processors/thrift_processor_test.go b/cmd/agent/app/processors/thrift_processor_test.go
@@ -16,7 +16,6 @@ package processors
 
 import (
 	"errors"
-	"fmt"
 	"testing"
 	"time"
 
@@ -196,7 +195,7 @@ func assertProcessorCorrectness(
 	metricsFactory *metrics.LocalFactory,
 	sizeF func() int,
 	nameF func() string,
-	counterType string,
+	format string,
 ) {
 	// wait for server to receive
 	for i := 0; i < 1000; i++ {
@@ -219,11 +218,9 @@ func assertProcessorCorrectness(
 	}
 
 	// agentReporter must emit metrics
-	batchesSubmittedCounter := fmt.Sprintf("tc-reporter.%s.batches.submitted", counterType)
-	spansSubmittedCounter := fmt.Sprintf("tc-reporter.%s.spans.submitted", counterType)
 	mTestutils.AssertCounterMetrics(t, metricsFactory, []mTestutils.ExpectedMetric{
-		{Name: batchesSubmittedCounter, Value: 1},
-		{Name: spansSubmittedCounter, Value: 1},
+		{Name: "tchannel-reporter.batches.submitted", Tags: map[string]string{"format": format}, Value: 1},
+		{Name: "tchannel-reporter.spans.submitted", Tags: map[string]string{"format": format}, Value: 1},
 		{Name: "thrift.udp.server.packets.processed", Value: 1},
 	}...)
 }
diff --git a/cmd/agent/app/reporter/tchannel/reporter.go b/cmd/agent/app/reporter/tchannel/reporter.go
@@ -71,11 +71,9 @@ func New(
 	zClient := zipkincore.NewTChanZipkinCollectorClient(thriftClient)
 	jClient := jaeger.NewTChanCollectorClient(thriftClient)
 	batchesMetrics := map[string]batchMetrics{}
-	tcReporterNS := mFactory.Namespace("tc-reporter", nil)
 	for _, s := range []string{zipkinBatches, jaegerBatches} {
-		nsByType := tcReporterNS.Namespace(s, nil)
 		bm := batchMetrics{}
-		metrics.Init(&bm, nsByType, nil)
+		metrics.Init(&bm, mFactory.Namespace("tchannel-reporter", map[string]string{"format": s}), nil)
 		batchesMetrics[s] = bm
 	}
 	return &Reporter{

diff --git a/cmd/agent/app/reporter/tchannel/reporter_test.go b/cmd/agent/app/reporter/tchannel/reporter_test.go
@@ -15,7 +15,6 @@
 package tchannel
 
 import (
-	"fmt"
 	"testing"
 	"time"
 
@@ -105,16 +104,11 @@ func submitTestJaegerBatch(reporter *Reporter) error {
 	return reporter.EmitBatch(batch)
 }
 
-func checkCounters(t *testing.T, mf *metrics.LocalFactory, batchesSubmitted, spansSubmitted, batchesFailures, spansFailures int, prefix string) {
-	batchesCounter := fmt.Sprintf("tc-reporter.%s.batches.submitted", prefix)
-	batchesFailureCounter := fmt.Sprintf("tc-reporter.%s.batches.failures", prefix)
-	spansCounter := fmt.Sprintf("tc-reporter.%s.spans.submitted", prefix)
-	spansFailureCounter := fmt.Sprintf("tc-reporter.%s.spans.failures", prefix)
-
+func checkCounters(t *testing.T, mf *metrics.LocalFactory, batchesSubmitted, spansSubmitted, batchesFailures, spansFailures int, format string) {
 	mTestutils.AssertCounterMetrics(t, mf, []mTestutils.ExpectedMetric{
-		{Name: batchesCounter, Value: batchesSubmitted},
-		{Name: spansCounter, Value: spansSubmitted},
-		{Name: batchesFailureCounter, Value: batchesFailures},
-		{Name: spansFailureCounter, Value: spansFailures},
+		{Name: "tchannel-reporter.batches.submitted", Tags: map[string]string{"format": format}, Value: batchesSubmitted},
+		{Name: "tchannel-reporter.spans.submitted", Tags: map[string]string{"format": format}, Value: spansSubmitted},
+		{Name: "tchannel-reporter.batches.failures", Tags: map[string]string{"format": format}, Value: batchesFailures},
+		{Name: "tchannel-reporter.spans.failures", Tags: map[string]string{"format": format}, Value: spansFailures},
 	}...)
 }