Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gRPC between collector and agent as default #1218

Closed
pavolloffay opened this issue Nov 26, 2018 · 4 comments
Closed

Use gRPC between collector and agent as default #1218

pavolloffay opened this issue Nov 26, 2018 · 4 comments
Assignees
@pavolloffay

Comments

@pavolloffay
Copy link
Member

We should decide when to use gRPC as default between agent and collector.

The first release with gRPC will be 1.9.0. If all goes well could we switch to the default in 1.10?
@yurishkuro
Copy link
Member

sgtm

@pavolloffay
Copy link
Member Author

1.9.0 has been released. I will change the default to gRPC as soon as possible to catch any bug in latest images before doing the final release.

@yurishkuro
Copy link
Member

We need to solve the retry situation, otherwise all the cross dock tests are still running with tchannel

@pavolloffay
Copy link
Member Author

+1 I (or anybody else) will have a look at it during the swap.

@yurishkuro yurishkuro mentioned this issue Feb 18, 2019
Closed
3 tasks
This was referenced Feb 25, 2019
Closed
Merged
@ghost ghost assigned pavolloffay Feb 26, 2019
@ghost ghost added the review label Feb 26, 2019
@ghost ghost removed the review label Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavolloffay pavolloffay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yurishkuro @pavolloffay