es client afterFn should check the case of resp == nil

[YEXINGZHE54]

Requirement - jaeger working with ElasticSearch

Problem - jaeger not checking whether es response is nil, and then process panic and exit

Proposal - what do you suggest to solve the problem or improve the existing situation?

add nil pointer check before using es response pointer, such as :

jaeger/pkg/es/config/config.go

Line 117 in 21e9ab4

if response.Errors {

Any open questions to address

[objectiser]

Hi @YEXINGZHE54 , how often does this problem occur?

Do you have the logs showing the panic - just curious if there is any other information that would indicate why a nil response would be returned?

[YEXINGZHE54]

hi, nil response would be returned in some rare case when es client interacting with ES server but got some unexpected failure. In detail: inside file gopkg.in/olivere/elastic.v5/bulk.go#191, the *BulkService.Do(ctx context.Context) (*BulkResponse, error) function will return a nil response if any error happened, and then inside file gopkg.in/olivere/elastic.v5/bulk_processor.go#531, *bulkWorker.commit(ctx context.Context) function call afterFn, without checking whether resp is nil; and then the nil resp would be passed into After callback defined inside jaeger config.go

[objectiser]

@YEXINGZHE54 Ok thanks - would you be interested in contributing a fix for this?

[YEXINGZHE54]

OK, I would like to do it.