Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive sampling strategies not updated in certain situations #1728

Closed
2 of 6 tasks
black-adder opened this issue Mar 28, 2017 · 2 comments · Fixed by jaegertracing/jaeger-client-java#655
Closed
2 of 6 tasks
Assignees
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement meta-issue An tracking issue that requires work in other repos

Comments

@black-adder
Copy link
Contributor

black-adder commented Mar 28, 2017

Under certain conditions, the collector might not return adaptive sampling strategies for certain operations which in turn means the operation will continue to use the existing sampling strategy and not be updated.

https://github.com/uber/jaeger-client-go/blob/master/sampler.go#L361 doesn't update existing strategies that are not apart of the passed in strategies.

Issue exists in all clients

@black-adder black-adder self-assigned this Mar 28, 2017
@yurishkuro
Copy link
Member

yurishkuro commented Mar 28, 2017

The expected outcome is that if the server did not return a strategy for operation X, the operation should fall back to the default sampler, even if it had its own strategy assigned previously.

Related issue: #1729

@yurishkuro yurishkuro reopened this Aug 13, 2019
@yurishkuro yurishkuro transferred this issue from jaegertracing/jaeger-client-go Aug 13, 2019
@yurishkuro yurishkuro added client-libs meta-issue An tracking issue that requires work in other repos good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement labels Aug 13, 2019
@vprithvi vprithvi reopened this Oct 3, 2019
@yurishkuro
Copy link
Member

Per #3362, we're sunsetting Jaeger clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement meta-issue An tracking issue that requires work in other repos
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants