Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink client metrics for sampled/unsampled spans/traces #1862

Open
yurishkuro opened this issue Oct 14, 2019 · 0 comments
Open

Rethink client metrics for sampled/unsampled spans/traces #1862

yurishkuro opened this issue Oct 14, 2019 · 0 comments

Comments

@yurishkuro
Copy link
Member

Requirement - what kind of business use case are you trying to solve?

As we're gradually introducing delayed sampling into clients (#1861), our current started_spans/started_traces metrics become less meaningful and do not reflect what happens.

Problem - what in Jaeger blocks you from solving the requirement?

Metrics are currently annotated with a sampled label (yes/no), but when sampling is delayed we don't know if the span/trace will be sampled later. In reverse, finished_spans metric does not have a label for sampled state.

Proposal - what do you suggest to solve the problem or improve the existing situation?

  • Introduce a 3rd value delayed for the sampled label on the xxx_started metrics.
  • Add sampled label to the xxx_finished metrics (currently it does not have this label).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant