Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tchannel reporter from agent #2105

Closed
1 of 3 tasks
pavolloffay opened this issue Mar 2, 2020 · 10 comments · Fixed by #2115
Closed
1 of 3 tasks

Remove tchannel reporter from agent #2105

pavolloffay opened this issue Mar 2, 2020 · 10 comments · Fixed by #2115

Comments

@pavolloffay
Copy link
Member

pavolloffay commented Mar 2, 2020

Remove tchannel reporter from agent.

TODO:

@pavolloffay
Copy link
Member Author

This might also close #1193 and #983

@eundoosong
Copy link
Contributor

If it's ok, I'd like to give it a shot

@pavolloffay
Copy link
Member Author

I have already started working on this one.

@pavolloffay
Copy link
Member Author

@yurishkuro any concerns from your side?

@yurishkuro
Copy link
Member

Yes, we’re still using it.

@pavolloffay
Copy link
Member Author

Are there any plans to migrate to gRPC inside Uber?

@pavolloffay
Copy link
Member Author

pavolloffay commented Mar 2, 2020

Tchannel (14267) is used for:

  • send span data from agent to collector
  • send sampling configuration from collector to agent
  • send baggage restriction from collector to agent - however this hasn't been fully open-sourced Baggage Whitelisting #373

For sampling strategies we have implemented gRPC pipe, but not for baggage restrictions.

Also, the tchannel receiver (14267) is also implemented in the OpenTelemetry collector.

@objectiser
Copy link
Contributor

Also, the tchannel receiver (14267) is also implemented in the OpenTelemetry collector.

This should be removed soon: open-telemetry/opentelemetry-collector#267

@yurishkuro
Copy link
Member

I don't know how "doable" this is, but if we could refactor all tchannel code into a complete separate location, then we could copy all of it into our internal repo, and then delete from master. My main concern is that it might be complicated to rip it out from Agent's builder.

NB: yes, we do plan to migrate to gRPC internally, but the work hasn't been prioritize yet, there are some dependencies on the load balancing behavior. We can probably commit to have it done in Q2 (cc @vprithvi )

@pavolloffay
Copy link
Member Author

I was able to move all tchannel to a single top level package and then use it in the current build #2112.

We could merge that and then in a second PR remove the tchannel from our components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants