-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tchannel reporter from agent #2105
Comments
If it's ok, I'd like to give it a shot |
I have already started working on this one. |
@yurishkuro any concerns from your side? |
Yes, we’re still using it. |
Are there any plans to migrate to gRPC inside Uber? |
Tchannel (14267) is used for:
For sampling strategies we have implemented gRPC pipe, but not for baggage restrictions. Also, the tchannel receiver (14267) is also implemented in the OpenTelemetry collector. |
This should be removed soon: open-telemetry/opentelemetry-collector#267 |
I don't know how "doable" this is, but if we could refactor all tchannel code into a complete separate location, then we could copy all of it into our internal repo, and then delete from master. My main concern is that it might be complicated to rip it out from Agent's builder. NB: yes, we do plan to migrate to gRPC internally, but the work hasn't been prioritize yet, there are some dependencies on the load balancing behavior. We can probably commit to have it done in Q2 (cc @vprithvi ) |
I was able to move all tchannel to a single top level package and then use it in the current build #2112. We could merge that and then in a second PR remove the tchannel from our components. |
Remove tchannel reporter from agent.
grpc
reportertchannel
reporter was deprecated in 1.16 Deprecate tchannel #1975.TODO:
The text was updated successfully, but these errors were encountered: