Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTEL collector exposes flags that are not used #2182

Closed
pavolloffay opened this issue Apr 16, 2020 · 1 comment
Closed

OTEL collector exposes flags that are not used #2182

pavolloffay opened this issue Apr 16, 2020 · 1 comment

Comments

@pavolloffay
Copy link
Member

For instance #2181 introduced all Jaeger collector flags to OTEL build. From the introduced flags only zipkin flags are needed.

From one point of view exposing all flags helps with backward compatibility (for drop-in replacement) - the process will not fail at startup on not recognized flag from Jaeger collector. On the other hand these some flags are noop.

There are two ways to go:
2. mark not used flags as noop/deprecated.

  1. remove not used flags

We could do this gradually, first just make them noop and then remove them once Jaeger collector will not be supported anymore.

@pavolloffay
Copy link
Member Author

For now OTEL components expose only flags that are being used.

Done in #2241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant