Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FOSSA integration #2432

Open
2 tasks
yurishkuro opened this issue Aug 29, 2020 · 2 comments
Open
2 tasks

Improve FOSSA integration #2432

yurishkuro opened this issue Aug 29, 2020 · 2 comments
Labels
help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

Related to FOSSA scanning introduced in #2347

  • make the check go red when license violations are discovered
  • make the scan report easily accessible, e.g. by clicking on the Details next to the check, and/or posting a summary as a PR comment
@ghost ghost added the needs-triage label Aug 29, 2020
@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement and removed needs-triage labels Aug 29, 2020
@idvoretskyi
Copy link
Contributor

@yurishkuro happy to address this:

make the check go red when license violations are discovered

It's so easy as adding an extra line to the configuration - f136083#diff-3e1f48f43ea04daf7c61b8915f2d1d94R28, but as we've discovered recently - FOSSA scan can take a huge amount of time and fail for some reason. Also, it may happen that FOSSA scan can find some licensing "issues" which are not the real issues, but the incorrect interpretation by their engine (we've discussed that with you, Yuri, via email), which were reported as bugs to FOSSA.

So I can add this easily, but we may want to revert this behavior back.

make the scan report easily accessible, e.g. by clicking on the Details next to the check, and/or posting a summary as a PR comment

Posting a summary as a PR comment is not possible, unfortunately (I've raised this up to FOSSA already). I'll investigate if we can make access to the reports easier.

The first thing that comes to my mind - adding a badge to the project README file: https://docs.fossa.com/docs/quick-import#getting-a-badge-pull-request-githubcom-only

@idvoretskyi
Copy link
Contributor

@yurishkuro I've noticed that you already have a FOSSA badge in the README, so updated a link here - #2446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Development

No branches or pull requests

2 participants