Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable OTLP port to be configurable via CLI flags #2563

Closed
objectiser opened this issue Oct 15, 2020 · 5 comments
Closed

Enable OTLP port to be configurable via CLI flags #2563

objectiser opened this issue Oct 15, 2020 · 5 comments
Assignees

Comments

@objectiser
Copy link
Contributor

objectiser commented Oct 15, 2020

Requirement - what kind of business use case are you trying to solve?

Allow users to change the port (currently 13133) used for the OTLP endpoint in the Jaeger OpenTelemetry Collector and Agent.

Problem - what in Jaeger blocks you from solving the requirement?

Currently other protocol endpoints can have their ports changed via CLI flags - but the OTLP port is fixed.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Add a new CLI flag to support configuring a different port for OTLP.

@joe-elliott
Copy link
Member

To give some history.

  • Generally we haven't added any additional flags for otel and all the cli flags are pulled from the existing Jaeger agent and collector. @pavolloffay may be able to add more here for the reasoning behind it.
  • The otlp port should be currently overridable by using the otel config file param.
  • For setting individual otel fields via the cli the plan was to use a set param. Unfortunately this was reverted and will be remerged once the linked issue is fixed.

@objectiser
Copy link
Contributor Author

Ok thanks @joe-elliott.

@jpkrohling I guess we could just detect/extract the overridden port from the OTel Config in the operator's CR and use that to adjust the collector/agent deployments?

@jpkrohling
Copy link
Contributor

The otlp port should be currently overridable by using the otel config file param.

Would we then end up having both flags (Jaeger) and a configuration file (OpenTelemetry Collector)?

@joe-elliott
Copy link
Member

joe-elliott commented Oct 15, 2020

Yes, it can be currently configured using a mix of Jaeger cli, Jaeger config file and an Otel Config file. The application attempts to merge all 3 sources into one. It can be confusing and, even though I've worked on it, I can't say exactly how all 3 interact without digging into the code and trying different configurations. It can also be fully configured by only specifying an otel collector configuration file.

Perhaps we should document an end goal and begin working towards that?

@objectiser
Copy link
Contributor Author

I'm closing this, as based on the current ideas we won't be supporting the previous concept of CLI flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants