-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable OTLP port to be configurable via CLI flags #2563
Comments
To give some history.
|
Ok thanks @joe-elliott. @jpkrohling I guess we could just detect/extract the overridden port from the OTel Config in the operator's CR and use that to adjust the collector/agent deployments? |
Would we then end up having both flags (Jaeger) and a configuration file (OpenTelemetry Collector)? |
Yes, it can be currently configured using a mix of Jaeger cli, Jaeger config file and an Otel Config file. The application attempts to merge all 3 sources into one. It can be confusing and, even though I've worked on it, I can't say exactly how all 3 interact without digging into the code and trying different configurations. It can also be fully configured by only specifying an otel collector configuration file. Perhaps we should document an end goal and begin working towards that? |
I'm closing this, as based on the current ideas we won't be supporting the previous concept of CLI flags. |
Requirement - what kind of business use case are you trying to solve?
Allow users to change the port (currently 13133) used for the OTLP endpoint in the Jaeger OpenTelemetry Collector and Agent.
Problem - what in Jaeger blocks you from solving the requirement?
Currently other protocol endpoints can have their ports changed via CLI flags - but the OTLP port is fixed.
Proposal - what do you suggest to solve the problem or improve the existing situation?
Add a new CLI flag to support configuring a different port for OTLP.
The text was updated successfully, but these errors were encountered: