Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics on the agent that can show connections status between agent with collection #2656

Closed
WalkerWang731 opened this issue Nov 26, 2020 · 0 comments · Fixed by #2657
Closed

Comments

@WalkerWang731
Copy link
Contributor

WalkerWang731 commented Nov 26, 2020

Requirement - what kind of business use case are you trying to solve?

Add metrics on the agent that can show connections status between the agent with collections.
We need monitoring of agent connection status in the production environment to ensure the agent connected.
But, so far, we can't get these metrics via http://jaeger-agent:14271/metrics, especially when the agent disconnected collections, current metrics not provide clear metrics to discover.
So I thought to provide this metric.

Problem - what in Jaeger blocks you from solving the requirement?

Not metrics to discover this case

When the agent disconnected, just only output the error log and can't provide relevant metrics. Make engineers in an unstable environment.

Proposal - what do you suggest to solve the problem or improve the existing situation?

As gRPC connects or changes metrics also change

Like below:

# HELP jaeger_agent_connection_status_connected_collector_status Connection status that jaeger-agent to jaeger-collector, 1 is connected, 0 is disconnected
# TYPE jaeger_agent_connection_status_connected_collector_status gauge
jaeger_agent_connection_status_connected_collector_status{protocol="grpc",target="127.0.0.1:14250"} 1

Any open questions to address

I had solved the issue, let me create a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant