Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby / Rails client #268

Closed
jalberto opened this issue Jul 13, 2017 · 11 comments
Closed

Ruby / Rails client #268

jalberto opened this issue Jul 13, 2017 · 11 comments
Labels
enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@jalberto
Copy link

Is it there any work to add a ruby client?

If it is not, Is it possible to use zipkin-ruby with jaeger?

@yurishkuro
Copy link
Member

There is currently no Jaeger client in Ruby. A contribution would be awesome (but I don't think Ruby opentracing API is finalized).

I don't know how zipkin-ruby sends the traces out of process, but if it's in zipkin thrift format over HTTP, then Jaeger backend can accept them.

@jalberto
Copy link
Author

@yurishkuro
Copy link
Member

Yes. I didn't follow it too closely as I don't know Ruby that well, but it looks like it might be in the "released" state already. @tedsuo do you know what the state of Ruby API?

@jalberto
Copy link
Author

jalberto commented Jul 13, 2017 via email

@yurishkuro
Copy link
Member

So as a guideline, the following is a rough outline for getting a new client out:

  1. setup new project, travis build, code coverage, release publishing, etc.
  2. implement basic tracer & span functionality with a simple 100% sampling & a configuration mechanism
  3. implement remote reporter with abstract sender
  4. implement UDP or HTTP sender or both
  5. implement other samplers (probabilistic, rate limiting)
  6. implement remote sampler that pulls sampling strategy from the agent
  7. implement adaptive sampler
  8. optionally other features like baggage whitelisting

Steps 5-8 could be added later, 1-4 are needed to get a minimal viable client.

@jalberto
Copy link
Author

jalberto commented Jul 13, 2017 via email

@tedsuo
Copy link

tedsuo commented Jul 14, 2017

@yurishkuro I've been concentrating on Java/Python/C++11, was going to look at ruby after python. The ruby API will need context management at some point just like the others, but otherwise I can say it is in production and working at LightStep.

@indrekj
Copy link

indrekj commented Aug 16, 2017

I published a very basic ruby client some time ago: https://github.com/salemove/jaeger-client-ruby

@jpkrohling
Copy link
Contributor

@indrekj would you be interested in having the Ruby client as part of this organization?

@jpkrohling jpkrohling added enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement client-libs labels Apr 2, 2019
@danielmbarlow
Copy link

For info I use opencensus-ruby in production to communicate with Jaeger via opencensus-ruby-exporter-jaeger and I'm pretty happy with it.

Notes:

@yurishkuro
Copy link
Member

Per #3362, we're sunsetting Jaeger clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Development

No branches or pull requests

6 participants