-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated TLS flags #2790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: albertteoh <albert.teoh@logz.io>
Signed-off-by: albertteoh <albert.teoh@logz.io>
Codecov Report
@@ Coverage Diff @@
## master #2790 +/- ##
==========================================
+ Coverage 95.88% 95.90% +0.02%
==========================================
Files 218 218
Lines 9615 9606 -9
==========================================
- Hits 9219 9213 -6
+ Misses 327 325 -2
+ Partials 69 68 -1
Continue to review full report at Codecov.
|
Signed-off-by: albertteoh <albert.teoh@logz.io>
yurishkuro
reviewed
Feb 5, 2021
Signed-off-by: albertteoh <albert.teoh@logz.io>
Signed-off-by: albertteoh <albert.teoh@logz.io>
Signed-off-by: albertteoh <albert.teoh@logz.io>
yurishkuro
approved these changes
Feb 5, 2021
bhiravabhatla
pushed a commit
to bhiravabhatla/jaeger
that referenced
this pull request
Feb 5, 2021
* Remove deprecated TLS flags Signed-off-by: albertteoh <albert.teoh@logz.io> * Add PR ref to changelog Signed-off-by: albertteoh <albert.teoh@logz.io> * Fix integration test Signed-off-by: albertteoh <albert.teoh@logz.io> * Add changelog deprecate entry for --es.tls Signed-off-by: albertteoh <albert.teoh@logz.io> * Add changelog deprecate entries for other storage types Signed-off-by: albertteoh <albert.teoh@logz.io> * Add remaining deprecated flags as identified by @yurishkuro Signed-off-by: albertteoh <albert.teoh@logz.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: albertteoh albert.teoh@logz.io
Which problem is this PR solving?
Short description of the changes