-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on github.com/grpc-ecosystem/grpc-gateway #2843
Comments
Hi, I would like to work on this issue |
@jeffy-mathew it's yours |
@yurishkuro I need some help in generating proto files, how to remove the dependency from generated proto files? |
oh, you may need to make a change to jaeger-idl repo and remove the respective annotations from these files:
|
about the changes in submodule |
Yes, a PR there and after it's merged update the submodule in this repo. |
As far as I can tell, we are not using it today. The motivation for it was to have a canonical proto-based JSON API that would be used by the UI as well as a public API. But there are issues with proto-based JSON (e.g. IDs are represented in base64 instead of hex)
and updating the UI is a large task that we don't have the cycles for. I suggest we remove this dependency altogether until the time we actually need it.
The text was updated successfully, but these errors were encountered: