Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful degradation of UDP client senders on EMSGSIZE #389

Closed
vprithvi opened this issue Sep 8, 2017 · 4 comments
Closed

Graceful degradation of UDP client senders on EMSGSIZE #389

vprithvi opened this issue Sep 8, 2017 · 4 comments
Labels
enhancement meta-issue An tracking issue that requires work in other repos

Comments

@vprithvi
Copy link
Contributor

vprithvi commented Sep 8, 2017

When attempting to send large spans, some clients hit a UDP's EMSGSIZE, which means that the data being sent is larger than the maximum UDP packet size.

Debugging this error is difficult because clients only log the error and increment a metric.

I propose that when clients get a EMSGSIZE back, they attempt to resend the Span after stripping out tags and logs, and inserting a UDP_SPAN_TOO_BIG tag, or something similar. I expect this to increase the success of sending a Span because the only variable sized fields are tags, logs, and operationName.

@jpkrohling
Copy link
Contributor

Perhaps a good first step is to add a WARN log entry + increase a counter in a specific (new?) metric.

@jpkrohling jpkrohling added meta-issue An tracking issue that requires work in other repos client-libs labels Apr 2, 2019
@yurishkuro
Copy link
Member

Maybe a better approach is for clients to run a form of a health check on the agent, e.g. submit a large packet of garbage data over UDP so that the agent can register the new client uuid, and then query the http config endpoint to see if the agent received such packet successfully. If it didn't, then the client can either start complaining loudly, or drop all spans and keep checking the health endpoint, possibly trying smaller max packet sizes.

@jpkrohling
Copy link
Contributor

I think we did talk about having something like that for the connectivity test. Perhaps as part of #1054?

@yurishkuro
Copy link
Member

Per #3362, we're sunsetting Jaeger clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement meta-issue An tracking issue that requires work in other repos
Projects
None yet
Development

No branches or pull requests

3 participants