Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cassandra] does not handle limit parameter correctly #411

Closed
trtg opened this issue Sep 20, 2017 · 3 comments
Closed

[cassandra] does not handle limit parameter correctly #411

trtg opened this issue Sep 20, 2017 · 3 comments

Comments

@trtg
Copy link

trtg commented Sep 20, 2017

I originally opened this on jaeger-ui here , but it seems the issue is in the rest API itself or something lower level than that

if i use the stock docker image for jaeger-query using the docker-compose setup below, I see the following reproducible behavior: clicking "find traces" while 'all' is selected will show 2 results, if the result limit is set to any value between 1 and 11. If I set the limit to a value between 12 and 22, I see 2 results. If the limit is between 23 and 34, I see 3 results. If the limit is 35 to 45, I see 4 results. If instead of "all" I pick any other operation name, I can see all the results.

`

jaeger_query:
image: jaegertracing/jaeger-query
dns:

  • 8.8.8.8
  • 8.8.4.4
    command: /go/bin/query-linux --query.static-files=/go/jaeger-ui/ --cassandra.keyspace jaeger_v1_datacenter1 --cassandra.servers cassandra.internal --cassandra.connections-per-host 2 --query.port 8380
    ports:
  • 8380:8380
@jpkrohling
Copy link
Contributor

Looks like there's a formatting error on the docker compose part. Would it be possible to fix it? It would also be helpful to have a couple of screenshots demonstrating what you are experiencing.

@trtg
Copy link
Author

trtg commented Oct 13, 2017

@jpkrohling did further investigation and compiled the screenshots.
@yurishkuro
so, doing a little more digging there seem to be a lot of issues when combining different query parameters in the jaeger UI. If you leave min and max duration blank, set operation name to all, and limit
to 11 you get back only 2 results:
limit 11

if you leave min and max duration blank, set operation name to all, and limit to 20, you get back only 3 results, as in this screen shot:
limit 20

if you leave min and max duration blank, set operation name to all, and limit to 23, you get back only 4 results, as in this screen shot:
limit 23

BUT, if you set max duration to 900ms, set operation name to all, and limit to 20, you get back 20 results, some of which vastly exceed the max duration that was specified:
limit 20, max duration 900ms

setting these same parameters directly in a curl request without the UI yields the same results, for example the curl request below with a limit of 23 retrieves 4 results (sometimes 5?!) so I'm not sure where in the jaeger stack the issue is- maybe jaeger-query?
curl 'http://jaeger.internal:16686/api/traces?end=1507873208059000&limit=23&lookback=1h&maxDuration&minDuration&service=kiip_service&start=1507869608059000' -H 'Accept: */*' -H 'Connection: keep-alive' -H 'Accept-Encoding: gzip, deflate' -H 'Referer: http://jaeger.internal:16686/search?end=1507871735265000&limit=23&lookback=1h&maxDuration&minDuration&service=kiip_service&start=1507868135265000' -H 'Accept-Language: en-US,en;q=0.8' -H 'User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.79 Safari/537.36' --compressed

@yurishkuro yurishkuro changed the title jaeger-query API does not handle limit parameter correctly when operation name is set to all [cassandra] does not handle limit parameter correctly Nov 10, 2018
@yurishkuro
Copy link
Member

Duplicate of #166

@yurishkuro yurishkuro marked this as a duplicate of #166 Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants