-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SASI index on dependency column family #790
Comments
btw, I suggest adding a "source" column to the schema, potentially to represent data coming from different sources, i.e. not just from traces (where source would be an aggregation job), but say from service mesh, or network sniffing. The UI diagram can aggregate all sources together, and use different viz to distinguish the links. |
I like this idea, but I don't think it should be part of the migration, I created #791 to capture this. |
I am not suggesting we implement all of the relevant business logic, but if we are already making a breaking schema change, why not include an extra field? |
Because it's unrelated to this change, and is unusable without the business logic. Why shouldn't the change be done along with the business logic? |
I'm thinking that changing the data model to include a date bucket while making the time stamp as a clustering key would enable us to maintain the current query patterns while removing the SASI index. The schema looks something like this: jaeger/plugin/storage/cassandra/schema/v001.cql.tmpl Lines 191 to 196 in d52969b
While the write path is largely unaffected, reads become a bit more involved, as we need to compute buckets that we want to retrieve dependencies from. We also need to update the spark dependencies job. The migration path seems to be the following:
|
While most SASI indexes were removed as part of #80, the one in the dependencies column family still exists, leading to problems when using older versions of cassandra that don't support SASI indexes, or using alternate storage like ScyllaDB .
We can update the
dependency
schema to not have SASI indexes, and provide a migration script from the old schema to the new schema.We should also ensure that https://github.com/jaegertracing/spark-dependencies works with the new schema.
The text was updated successfully, but these errors were encountered: