Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use visual libraries to make the webpage more attractive and easy to use #5

Open
jai-dewani opened this issue Sep 20, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers visual

Comments

@jai-dewani
Copy link
Owner

Maybe Material UI?
Refer to different UI libraries: https://www.codeinwp.com/blog/react-ui-component-libraries-frameworks/

@jai-dewani jai-dewani added enhancement New feature or request good first issue Good for newcomers visual labels Sep 20, 2020
@andylim0221
Copy link

I'm interested in contributing to this. Do you have the UI design for this website?

@jai-dewani
Copy link
Owner Author

No, I don't have a UI design to show you, but here is an idea of what I think will look good,

Keep the current layout, navbar at the top, the rest of the screen divided between the meme and the editing functionalities like adding text and whatever we plan to add next. The ratio could be 1:1 or 1:2 giving more screen to the meme 🤭

Do you have specific design views?

@andylim0221
Copy link

I don't, but basically I was referring to this meme generator website. I could try out the suggestion which you have provided.

@andylim0221
Copy link

do you mind if i convert meme generator page into functional component?

@jai-dewani
Copy link
Owner Author

Yeah, I like the popular section on the website you provided...I was aiming to create a place where users can select meme from a catalog or something...maybe you can include that if it fits, feel free to try out any design you find suitable. Just the main motive is to keep the UI simple and easy to use without any instructions :)

I used the class component because I need componentDidMount and componentDidUpdate functions. I know it is possible to do the same in the functional component also but I don't have much experience with it.

Btw most of the display logic is in displayMeme.js which has a function component, won't that work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers visual
Projects
None yet
Development

No branches or pull requests

2 participants