Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portable Extension's ObserverMethod doesn't expose the declaring Bean #563

Closed
Ladicek opened this issue Nov 23, 2021 · 2 comments · Fixed by #578
Closed

Portable Extension's ObserverMethod doesn't expose the declaring Bean #563

Ladicek opened this issue Nov 23, 2021 · 2 comments · Fixed by #578
Assignees
Labels
Lite Related to CDI Lite lite-extension-api Issues related to CDI Lite extension API proposal

Comments

@Ladicek
Copy link
Contributor

Ladicek commented Nov 23, 2021

The Build Compatible Extension API has a method ObserverInfo.bean() that provides access to the bean that declares given observer. The Portable Extension API only has ObserverMethod.getBeanClass() (providing access to the class that declares given observer).

To keep BCExtensions a strict subset of PExtensions, either we have to remove ObserverInfo.bean(), or add ObserverMethod.getDeclaringBean() (copying the name from Weld's ObserverMethodImpl, which does expose the declaring bean).

@Ladicek Ladicek added Lite Related to CDI Lite lite-extension-api Issues related to CDI Lite extension API proposal labels Nov 23, 2021
@manovotn
Copy link
Contributor

manovotn commented Dec 7, 2021

@Ladicek do we need this in CR?

@Ladicek
Copy link
Contributor Author

Ladicek commented Dec 7, 2021

Ah ah. Yes I think we need to select one of the 2 options, otherwise Build Compatible Extensions can't be implemented on top of Portable Extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lite Related to CDI Lite lite-extension-api Issues related to CDI Lite extension API proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants