-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jakarta-ize your Specification document (if applicable) #99
Comments
As per the Release Plan, the following items needs to be updated in the spec document:
So any section that is relevant to the above points needs to be updated (removed/modified). Please look into these first. Other items that need to be updated are:
|
Code changes in #100 |
What about the term "EJB Container"? Is it OK to leave it unchanged or we need to rename it to something like "Enterprise Beans Container", "EB Container", or "JEB Container" (Jakarta Enterprise Beans)? The JMS spec refers to the EJB Container (e.g. here) so I wonder whether we need to fix it and how. |
Specs I've worked on have used "Jakarta Enterprise Beans" and then just Enterprise Beans for shortening no acronym. Not sure if that is a policy though. |
But "EJB Container" is a term defined in the specification, here: https://github.com/eclipse-ee4j/ejb-api/blob/02302609c4d1324d060fd703597727e7f47f4b55/spec/src/main/asciidoc/opt/ClientViewOfEntityBean.adoc#ejb-container. It's not directly related to the name of the specification. It's similar to the |
Maybe you could call it "Enterprise Beans Container" where there's enough space. I wouldn't do "JEB" let's not forget, that "JMS" in that case is also not the proper acronym any more, it would just be "JM" now ;-D |
The optional document is still under review #96. "Enterprise Beans Container" is advised, since the goal is not to refer to any Oracle trademarked acronyms. EJB is allowed in class, package or project name. |
In that case, I will use "Enterprise Beans Container" wherever applicable |
@hussainnm I have gone through the modify/remove items and will soon have a look at how much I can do for the remaining items that you mentioned |
Additional items to be covered as defined by @hussainnm : When the Chapter 10 "Support for Distributed Interoperability" is removed from the Core Features document, there are references made within the document:
|
Hi, Do these items actually need change because they are referred from the removed "Support for Distributed Interoperability" chapter? Are these paragraphs therefore become obsolete? I'm not sure though...
I'm not sure what to make from the Acknowledgements section. It now states that EJB is the result of efforts from the Enterprise Beans 3.2 Expert Group , conducted as part of JSR-345 under the Java Community Process Program. And then a lot of names. I suppose it has to change to the Jakarta EE Specification Process (JESP), but what to make of the list of names? |
For Chapter 8 and 9 no need to change anything. For Section 15.3 even I am not clear on the implications of the change. This is the relevant part in this section:
You can change the title for Acknowledgements to Acknowledgements for Enterprise Beans 3.2 and keep the content as it is. Add a new Acknowledgement section that states the current release was done under JESP. |
I'm not sure if Hussain is available, otherwise anybody else that could review my PR? |
Looks like there is a huge backlog of PRs, the oldest from 2017 ;-O |
That may be so, but why do you mention that? The PR referenced here is for ticking off a piece of the Jakarta EE 9 puzzle. It appears these others are less important then and not critical for EE 9? |
If there's no conflict, then it should be possible to merge that. |
Maybe some PRs could also be labeled, but not sure, if you can do that when raising it. |
Ah like that :). Well it seems that I can only change the title, not the labels |
The "Linked pull requests" field would also be a nice feature to use here imho. Will try to take these things into account in the future |
@hussainnm can you please specify which exact changes are still open for the core specification document? I will then process these.
This should apply for all files mentioned in: https://github.com/eclipse-ee4j/ejb-api/blob/master/spec/src/main/asciidoc/enterprise-beans-spec-core.adoc
I can of course go through the complete set of instructions as described in https://github.com/jakartaee/specification-committee/blob/master/steps_javaee_to_jakartaee.adoc, if thats the right place to start
The text was updated successfully, but these errors were encountered: