-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCK Challenge for JDBC TCK tests that convert String values like 999999999999999
to Float that fail on Java 21
#1260
Comments
@LanceAndersen (lead of the JDBC Specification) asked if we tried to modify the Note that the TCK dml/ddl files are intended to be modified as needed for the backend/platform.
|
I think that we will soon have another EE 10 Platform TCK release to address TCK challenges like this one. I haven't had time to research test changes related to this challenge and I likely will be heads down on EE 11 TCK test refactoring until that is further along (along with others). So this is looking like something that we will need to exclude the tests for instead of correcting for EE 10. Perhaps the test correction could be made for EE 11 as we will soon hit the same issues there. |
Thanks to some investigatory work by @mswatosh, we think that a value of |
@LanceAndersen as per ^ we are trying to test with a change from For easier reading, the problematic value is |
For the record, both Decimal_Tab (for test 177) and Numeric_Tab (for test 179) need to be updated, but this does seem to work for me with Open Liberty. Assuming we get agreement from Lance, I can make that change. Both the 10.0.x and the tckrefactor branches? |
I think it is a Platform concern to deal with at this point based on the feedback that we have already received. Please do create ( |
@brideck I'll create a pull request for the JDBC change. |
This will be closed when an EE 10 Platform TCK release contains the merged fix. |
https://issues.redhat.com/browse/WFLY-18896 reported the following TCK test failures:
Which led to issue https://issues.apache.org/jira/browse/DERBY-7160 to be opened and https://wildfly.zulipchat.com/#narrow/stream/174184-wildfly-developers/topic/Pass.20Platform.20TCK.20jdbc.2Eee.2EcallStmt.20tests.20on.20Java.2021 chat discussion in which Ladislav Thon pointed to the https://bugs.openjdk.org/browse/JDK-4511638 issue that was fixed for Java 19 which looks like the likely change.
Echoing discussion from https://issues.apache.org/jira/browse/DERBY-7160:
The text was updated successfully, but these errors were encountered: