Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoding on getContextPath of HttpServletRequest and ServletContext #163

Closed
glassfishrobot opened this issue Sep 12, 2016 · 5 comments
Closed
Assignees

Comments

@glassfishrobot
Copy link

The first paragraph of the spec for getContextPath() method on HttpServletRequest states():

"The container does not decode this string."

The first paragraph of the corresponding method on ServletContext does not have this statement, but is otherwise semantically equivalent.

This JIRA seeks to have the statement added to ServletContext.getContextPath().

@glassfishrobot
Copy link
Author

@glassfishrobot Commented
Reported by @edburns

@glassfishrobot
Copy link
Author

@glassfishrobot Commented
gregwilkins said:
rather than have that statement added to ServletContext.getContextPath(), there are other alternatives:

  • document the different behaviour in the javadoc.
  • accept that the decoding on the Request version was a cut and paste error and remove.
  • accept that the decoding on the Request version was a cut and paste error and replace with "The path returned is the containers preferred encoding of the context path string", so as to limit the applications exposure to non-normalized client supplied strings.

@glassfishrobot
Copy link
Author

@glassfishrobot Commented
This issue was imported from java.net JIRA SERVLET_SPEC-163

@glassfishrobot
Copy link
Author

@markt-asf
Copy link
Contributor

This is being addressed as part of #18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants