Skip to content

Commit 8ad35b2

Browse files
committed
Modernize localize script, use new XML library
This file is pretty much the same as it was when it was committed in 2017; these days, we can write clearer code with async/await and new FS APIs. Additionally, we can improve the performance of this script by using a newer/faster/maintained XML library. This will enable us to run the script unconditionally in a later commit.
1 parent 9f8832c commit 8ad35b2

File tree

3 files changed

+100
-157
lines changed

3 files changed

+100
-157
lines changed

Diff for: package-lock.json

+39-71
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: package.json

+2-3
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@
5151
"@types/node": "latest",
5252
"@types/source-map-support": "latest",
5353
"@types/which": "^2.0.1",
54-
"@types/xml2js": "^0.4.11",
5554
"@typescript-eslint/eslint-plugin": "^5.33.1",
5655
"@typescript-eslint/parser": "^5.33.1",
5756
"@typescript-eslint/utils": "^5.33.1",
@@ -67,6 +66,7 @@
6766
"eslint-plugin-jsdoc": "^39.3.6",
6867
"eslint-plugin-local": "^1.0.0",
6968
"eslint-plugin-no-null": "^1.0.2",
69+
"fast-xml-parser": "^4.0.11",
7070
"fs-extra": "^9.1.0",
7171
"glob": "latest",
7272
"hereby": "^1.6.3",
@@ -79,8 +79,7 @@
7979
"node-fetch": "^3.2.10",
8080
"source-map-support": "latest",
8181
"typescript": "^4.8.4",
82-
"which": "^2.0.2",
83-
"xml2js": "^0.4.23"
82+
"which": "^2.0.2"
8483
},
8584
"scripts": {
8685
"test": "hereby runtests-parallel --light=false",

0 commit comments

Comments
 (0)