Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename style.scss to something safer #43

Open
TheJaredWilcurt opened this issue Mar 9, 2016 · 2 comments
Open

Rename style.scss to something safer #43

TheJaredWilcurt opened this issue Mar 9, 2016 · 2 comments

Comments

@TheJaredWilcurt
Copy link

If someone wants to use Bower to install Sassline, and then use bower_compents\sassline\assets\sass as a location to look for items being imported they'd have to use the generic @import "style" which is not very descriptive and would lend itself to importing in the wrong file from a different directory.

style.scss should be renamed to sassline.scss.

See how the following mixin libraries follow this same pattern:

Code Source
@import "buttons"; github.com/alexwolfe/Buttons
@import "saffron"; github.com/corporadobob/saffron
@import "sassmatic"; github.com/DarbyBrown/sassmatic
@import "scut"; github.com/davidtheclark/scut
@import "su"; github.com/ericam/susy
@import "susy"; github.com/ericam/susy
@import "susyone"; github.com/ericam/susy
@import "andy"; github.com/gillesbertaux/andy
@import "typesettings"; github.com/ianrose/typesettings
@import "animate"; github.com/Igosuki/compass-mixins
@import "compass"; github.com/Igosuki/compass-mixins
@import "lemonade"; github.com/Igosuki/compass-mixins
@import "style"; github.com/jakegiltsoff/sassline
@import "sassy-buttons"; github.com/jhardy/Sassy-Buttons
@import "bluebird"; github.com/kalebheitzman/bluebird
@import "sass-easing"; github.com/kingscooty/sass-easing
@import "breakpoint"; github.com/lesjames/breakpoint
@import "css3-mixins"; github.com/matthieua/sass-css3-mixins
@import "cssowl"; github.com/owl-stars/cssowl
@import "spice"; github.com/spice-sass/spice
@import "bourbon-deprecated-upcoming"; github.com/thoughtbot/bourbon
@import "bourbon"; github.com/thoughtbot/bourbon
@import "neat"; github.com/thoughtbot/neat

Since this may be a breaking change for those who explicitly targeted bower_compents\sassline\assets\sass\style.scss you should include a major version bump from v2.1.2 to v3.0.0.

@jakegiltsoff
Copy link
Owner

@TheJaredWilcurt I’ll think on this. This isn’t the direction I wanted to take the project, it is more of a boilerplate / starting point than an add-on unit. I can see the benefit of the route though.

@TheJaredWilcurt
Copy link
Author

@jakegiltsoff I was just adding mixin libraries to Scout-App 2, and was going to include this one out of the box by default, but couldn't do it with "style" as the name.

If it isn't meant to be used as a dependency I can just remove it from the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@jakegiltsoff @TheJaredWilcurt and others