Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android compile error when new architecture is enabled on r-n 0.74+ #15

Closed
hexadecy opened this issue Oct 4, 2024 · 1 comment · Fixed by #20
Closed

Android compile error when new architecture is enabled on r-n 0.74+ #15

hexadecy opened this issue Oct 4, 2024 · 1 comment · Fixed by #20

Comments

@hexadecy
Copy link
Contributor

hexadecy commented Oct 4, 2024

react-native: 0.74.5
react-native-localization-settings: 1.0.2

gradle.properties:
newArchEnabled=true

/node_modules/react-native-localization-settings/android/src/main/java/com/localizationsettings/LocalizationSettingsModule.kt:14:1 Class 'LocalizationSettingsModule' is not abstract and does not implement abstract base class member protected/*protected and package*/ abstract fun getTypedExportedConstants(): (Mutable)Map<String!, Any!>! defined in com.localizationsettings.LocalizationSettingsSpec

I understand that with the new arch (since r-n 0.74) getConstants() is not called and is replaced by getTypedExportedConstants().

I'm searching for how to support both the new and the old arch.

@hexadecy hexadecy changed the title Android compile error when new architecture enabled Android compile error when new architecture is enabled Oct 4, 2024
@hexadecy
Copy link
Contributor Author

hexadecy commented Oct 5, 2024

I've made a PR #16.

@hexadecy hexadecy changed the title Android compile error when new architecture is enabled Android compile error when new architecture is enabled on rn 0.74+ Oct 5, 2024
@hexadecy hexadecy changed the title Android compile error when new architecture is enabled on rn 0.74+ Android compile error when new architecture is enabled on r-n 0.74+ Oct 5, 2024
@jakex7 jakex7 closed this as completed in #20 Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant