Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion, can we count the jWeek number, starting from the first complete week of the year? #257

Open
s11eta1yek opened this issue Nov 25, 2023 · 1 comment

Comments

@s11eta1yek
Copy link

Hello

I think that jWeek function should return the first complete week of the year as 1, and before that, it should be 0, meaning the week started in last year.

Right now, even if the year starts on the last day of the week, it will still count that as the first week of the year, which doesn't make much sense.

@behrang
Copy link
Member

behrang commented Jan 26, 2024

This has 2 parts:

  1. How to change the code for this change of counting? I can't do it myself now, because I'm busy with other projects.
  2. How to avoid breaking usage in old code that is depending on old behavior? This is very hard since we don't know who uses what. Maybe this change can be activated with a flag or config.

Does it really worth it to do the above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants