Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests requiring at least version 0.88 if requirement is met #108

Open
stefan6419846 opened this issue Dec 21, 2022 · 3 comments
Open

Comments

@stefan6419846
Copy link

At the moment, two tests will always be skipped as they require at least poppler 0.88 which might not be available in all environments. When building own wheels for the package, it would be nice to be able to run them nevertheless if at least version 0.88 is available to verify the correct behavior before uploading.

It might make sense to expose the poppler version embedded into the Python package as well, due to it being rather variable and by (nearly) no means tied to a specific version of this package at all.

@jalan
Copy link
Owner

jalan commented Dec 21, 2022

Good idea, will do.

It might make sense to expose the poppler version embedded into the Python package as well

Poppler's not embedded, but dynamically loaded, but yeah, I'll look into this too.

@stefan6419846
Copy link
Author

Poppler's not embedded, but dynamically loaded, but yeah, I'll look into this too.

I am aware of that and might have used a wrong wording here - we primarily link against the corresponding libraries. Speaking of manylinux wheels, there still are shared objects linked in, but as they are part of the actual wheel, one might consider them "embedded".

@jalan
Copy link
Owner

jalan commented Dec 22, 2022

one might consider them "embedded"

Good point--in the context of wheels that makes sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants