Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] update syn version in binrw_derive to 2 #285

Open
Neutron3529 opened this issue Aug 9, 2024 · 2 comments
Open

[Feature Request] update syn version in binrw_derive to 2 #285

Neutron3529 opened this issue Aug 9, 2024 · 2 comments

Comments

@Neutron3529
Copy link

Currently lots of famous crate, including clap_derive, thiserror_impl uses syn with version 2, updating the version of syn to 2 might save several seconds of compile time.

I'm just wondering whether there exists such plan, since I tried update the syn version, but failed since impl<T> quote::spanned::Spanned for SpannedValue<T> never possible due to the :Sealed limitation.

I have to firstly read the full code and then I can updating the code.

I know how much the work is, thus I'm just wonder.

@csnover
Copy link
Collaborator

csnover commented Aug 9, 2024

That trait sealing change is why the version is not updated. There’s no plan to update unless someone else does the work. Getting syn to do what we need it to do sucked (due to a combination of missing specialisation in rustc and the design of syn making it impossible to get access to certain things, though I don’t remember any more what those things are).

@Neutron3529
Copy link
Author

Thank you for your reply, feel free to close such issue if it is needed:)
(or keep it open until someone decided to help update the syn version to 2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants