-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: proposed integration of sim-ln in polar #829
Comments
Wow! This looks very cool. Great work on this so far 🔥 Thanks for opening this up for discussion early in your development. I would like to provide some feedback.
Polar currently uses volumes that are mapped to directories on the host machine. The
While i do like the look of the icon toggles, I'd worry that not many people would notice them there. This activities configuration may standout more if you had two tabs at the top, one for "Network" and the other for "Simulation" (or "Activities").
|
I'm glad you like the proposal. In light of that, I'd open a draft pr as soon as possible.
Yes, this is the direction I also have in mind to take 🤠
That's a valid point. I'll make the necessary changes. Do you prefer "Simulation" to "Activities"?
To hide/show the activity configuration form. The idea is that if there are existing simulation activities in a network, we hide the config form to better display the existing activities. Otherwise, we show the form.
This makes sense. Will do that.
Sure. |
I think term "Activities" is a bit vague without additional context. It may be better to use something more specific that conveys "simulate routing activity on the nodes" in a word or two. I don't have any strong opinions on what term to use other than for it to be intuitive. Some quick ideas I have are Simulation, Simulations, Simulate, SimLN, Auto-Routing, Auto-Pay. Maybe you can ask the SimLN team if they have a preference. Since this will be the entry point into the feature, it makes sense to put a bit of thought into it. |
In from the sidelines here, but no strong preference on our end either - Auto-Pay seems pretty cool to me 😎 |
This is exciting! eventually including some UX for reporting simulation results either while running live or for past simulations would be cool |
I am opening this issue to propose the integration of sim-ln in Polar for automated payment activity generation between running nodes.
The requirements to add sim-ln are:
The first step involves adding activity generation with user-defined payment flows. The simulator can also generate random activity based on the open channels.
I have started development of this feature in this branch and plan to open a draft pull request soon.
Below is the expected flow with screenshots of where development is ATM.
Network Designer
(default) and theActivity Designer
Ideas and criticism are welcome. I hope this excites you as it does me.
The text was updated successfully, but these errors were encountered: