We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making .stop() and .reset() causes the scroll slider never to be updated. This is because in the stop method, this.scrollRAF must be nulled.
.stop()
.reset()
stop
this.scrollRAF
if (cAF) { cAF(this.scrollRAF); }
should be changed to:
if (cAF) { cAF(this.scrollRAF); this.scrollRAF = null; }
better yet:
if (this.scrollRAF) { // only call cAF if really necessary (pending raf) cAF(this.scrollRAF); this.scrollRAF = null; }
The text was updated successfully, but these errors were encountered:
I could make a PR but the project is written in CS and I never ever wrote in CS, so I could mess things up.
Sorry, something went wrong.
Thanks for reporting this too!
4826c40
Made a fix. Please test if it works.
Works!
No branches or pull requests
Making
.stop()
and.reset()
causes the scroll slider never to be updated. This is because in thestop
method,this.scrollRAF
must be nulled.should be changed to:
better yet:
The text was updated successfully, but these errors were encountered: