Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge strategy of recent PRs #240

Closed
9 tasks done
krystophny opened this issue Dec 26, 2024 · 3 comments
Closed
9 tasks done

Merge strategy of recent PRs #240

krystophny opened this issue Dec 26, 2024 · 3 comments

Comments

@krystophny
Copy link
Contributor

krystophny commented Dec 26, 2024

To simplify reviews and discussion here is a summary of the recent PRs, and a proposed merge order:

(I rebased #236 and #233 on #239 and applied all patches in order onto master on https://github.com/itpplasma/f90wrap for testing.)

  • Finally, since Fix issue 157 #158 is stale some time now - should it be merged or discarded?
@jameskermode
Copy link
Owner

Thanks @krystophny, very useful to have a rationalised TODO list. I'll try to use the start-of-the-year lull to get through this. Agree #157 is stale and should be discarded, that's the easiest one so have done immediately.

@jameskermode
Copy link
Owner

First few are merged but I'll hold off here pending a decision on removing pytest dependency from #239 and resolution of the CI failures in #242

@krystophny
Copy link
Contributor Author

Removed the dependency in #243 , and noticed #242 only now. I have a quick look also there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants