Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2.0 #105

Open
3 tasks
jamesmartin opened this issue Nov 13, 2019 · 3 comments
Open
3 tasks

Version 2.0 #105

jamesmartin opened this issue Nov 13, 2019 · 3 comments
Assignees
@jamesmartin
Milestone
2.0

Comments

@jamesmartin
Copy link
Owner

jamesmartin commented Nov 13, 2019 •
edited
Loading

A laundry list of things we'd like to do for version 2.0:

  • Drop support for older Rails versions (ideally only support Rails 6 and Rails 5)
    • We'll keep a v1 branch around and patched for security vulnerabilities while people migrate to v2
  • Remove the inline_svg helper in favor of the new specific helpers introduced in Support both Sprockets and Webpacker #103
  • ...
@jamesmartin jamesmartin self-assigned this Nov 13, 2019
@jamesmartin jamesmartin added this to the 2.0 milestone Nov 13, 2019
@DanielJackson-Oslo
Copy link
Contributor

Would love to keep inline_svg as the default method, and instead be able to configure if it should point to sprockets or webpacker. Feels a bit weird to me to have to define in respective view files if I use sprockets or webpacker, and have to change all my svg view code if I change from one to the other!

@jamesmartin
Copy link
Owner Author

Feels a bit weird to me to have to define in respective view files if I use sprockets or webpacker, and have to change all my svg view code if I change from one to the other!

Agreed. 👍

@DanielJackson-Oslo
Copy link
Contributor

Feels a bit weird to me to have to define in respective view files if I use sprockets or webpacker, and have to change all my svg view code if I change from one to the other!

Agreed. 👍

Does that mean we can get rid of the depreciation warning for using inline_svg? I can make a PR for that, if you'd like?

@DanielJackson-Oslo DanielJackson-Oslo mentioned this issue Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesmartin jamesmartin

Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@jamesmartin @DanielJackson-Oslo