Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dasherize Data Attributes #51

Closed
jamesmartin opened this issue Nov 21, 2016 · 2 comments
Closed

Dasherize Data Attributes #51

jamesmartin opened this issue Nov 21, 2016 · 2 comments
Milestone
0.11.1

Comments

@jamesmartin
Copy link
Owner

Reported in #50. We should "dasherize" the names of data attributes:

# Default:
<%= link_to 'a', '#', data: { tooltip_id: 'id', tooltip_placement: 'right' } %>
<a data-tooltip-id="id" data-tooltip-placement="right" href="#">a</a>

# InlineSvg:
<%= inline_svg 'caret-up.svg', data: { tooltip_id: 'id', tooltip_placement: 'right' } %>
<svg xmlns="http://www.w3.org/2000/svg" width="34" height="34" viewBox="0 0 34 34" data-tooltip_id="id" data-tooltip_placement="right">
  <path d="M17 4.541l16.04 23.919h-32.08z"></path>
</svg>

/cc @ollie
This was referenced Nov 21, 2016
Closed
Merged
@jamesmartin jamesmartin modified the milestones: 0.11.1, 0.11.0 Nov 22, 2016
@jamesmartin
Copy link
Owner Author

Released in v0.11.1.

@ollie
Copy link

ollie commented Nov 25, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.1
Development

No branches or pull requests
2 participants
@ollie @jamesmartin