Not working without sprockets

[askehansen]

When using this in a new rails 6 app i get the error:
undefined method 'assets' for #<Rails::Application::Configuration:0x00007ffba1c234f0>

I guess it fails here because rails 6 now uses webpacker instead of sprockets:

inline_svg/lib/inline_svg/static_asset_finder.rb

Line 16 in 8e9c3af

if ::Rails.application.config.assets.compile

[jamesmartin]

@askehansen thanks for opening this issue. 👍

I guess it fails here because rails 6 now uses webpacker instead of sprockets:

That seems the most likely cause of the problem. I haven't had a chance to try this gem with a vanilla Rails 6 project yet. I'll put this on my todo list.

[jamesmartin]

Just tested by upgrading a Rails 5.2 app to Rails 6.0.0.rc1: inline_svg still works with Rails 6 if you use Sprockets.

I'll have to figure out what's needed to make it work with Webpacker.

[askehansen]

Okay so I just noticed I had --skip-sprockets in my ~/.railsrc file.
That means this issue is not regarding rails 6, but an issue if you disable sprockets and use webpacker in favor of sprockets. Sorry for the confusion!

However I would like to contribute in making this gem not relying on sprockets.

What is the disadvantage of doing this instead?

class StaticAssetFinder
...

  def pathname
    Rails.root.join('assets', @filename)
  end
end

[askehansen]

I realized I can write my own asset file loader and just use that instead:

class BasicAssetFileLoader
  def self.named(filename)
    File.open("app/assets/#{filename}", "rb") do |file|
      file.read
    end
  end
end

InlineSvg.configure do |config|
  config.asset_file = BasicAssetFileLoader
end

Again, sorry for the confusion and not reading the documentation!
And thanks for a great gem! 😊👍

[jamesmartin]

Added support for Webpacker in v1.5.0