Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Circular selection #13

Open
timshannon opened this issue Mar 29, 2018 · 2 comments
Open

Feature request: Circular selection #13

timshannon opened this issue Mar 29, 2018 · 2 comments

Comments

@timshannon
Copy link

Just what the title says. I like Croppr because it's very lightweight, and straight forward. Other cropping libraries are trying to do everything, but all I need is a simple selection like this library provides, however one feature that I would like would be circular selections.

I may try and throw together a PR as well, if I get a chance.

@jamesssooi
Copy link
Owner

Hi @timshannon, glad to hear that enjoy Croppr's simplicity. Circular selections will definitely be a great addition with minimal extra code, since some of it can be done simply via CSS and border-radius. However, the dark overlay mechanism will need to be rethought since the CSS clip property doesn't seem to support circular clipping paths. clip-path does, but we will lose IE & Edge support.

I might try to throw something together one of these days, or do feel free to make a PR if you have the time!

@lorado
Copy link

lorado commented Sep 14, 2018

Some updates here?

Quick and dirty idea: a transparent overlay with border-radius: 50% and box-shadow: 0 0 0 2000px rgba(0,0,0,0.5). Then simply remove border-raidus and uou have a square. But I don't really know, if so huge box-shadow somehow impact performance...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants