isResolved should be named isFulfilled

[julien-f]

AFAIU, resolved means that the promise is fulfilled (has a value) or is chained to another promise (which might not be settled).

[iamstarkov]

afaik, isFullfilled = (isResolved || isRejected)

[julien-f]

Nope, that's (almost) settled.

isSettled = isFulfilled || isRejected

And in fact, resolved is even an alias for settled (source).

isResolved = isSettled || isChainedToOtherPromise

[iamstarkov]

you are right

[jamiebuilds]

We don't currently expose the word fulfilled anywhere in the Promise api. Promise.resolve is exposed though.

[ljharb]

That difference is because resolving is a verb that can include resolving to another promise's state - although I prefer the term "resolve" here, "fulfill" is indeed correct. This has its roots in E's promises.

The spec's intention was for the new Promise executor's arguments to be named "fulfill, reject" - altho the community tends to call them "resolve, reject".

[jamiebuilds]

My point was that the name of the argument is not exposed as either fulfill or reject. The only place a name is exposed is Promise.resolve and I would rather match that naming.

[ljharb]

Right, but "is resolved" doesn't mean the same thing as "is fulfilled", and Promise.resolve does not guarantee you get a fulfilled promise - Promise.resolve(pendingPromise) gives you a pending promise. Thus "is resolved" isn't actually useful, since all that tells you is that the Promise's state is either fulfilled, rejected, or delegated to another Promise. "is fulfilled" is what tells you that it is irrevocably settled with a non-rejection.

[domenic]

https://github.com/domenic/promises-unwrapping/blob/master/docs/states-and-fates.md

[domenic]

The spec's intention was for the new Promise executor's arguments to be named "fulfill, reject" - altho the community tends to call them "resolve, reject".

False. The resolve() argument resolves, not fulfills, e.g. try resolve(Promise.reject(new Error())).

[ljharb]

Oops, you are indeed correct. Is the rest of my statement still accurate?

[domenic]

Yeah

[jamiebuilds]

Changed api and used fulfilled